Skip to content

[spectec] Automate extraction of validation rules for prose generation#2147

Merged
rossberg merged 18 commits intomainfrom
soundness.spectec
Apr 27, 2026
Merged

[spectec] Automate extraction of validation rules for prose generation#2147
rossberg merged 18 commits intomainfrom
soundness.spectec

Conversation

@f52985
Copy link
Copy Markdown
Collaborator

@f52985 f52985 commented Apr 22, 2026

This PR automates the extraction of validation rules as targets for prose generation, as discussed in PR #2125.

Copy link
Copy Markdown
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rossberg
Copy link
Copy Markdown
Member

There are still changes to test expectations for test-splice. They actually look somewhat suspicious.

@rossberg
Copy link
Copy Markdown
Member

Ping @f52985, this still needs updating test expectations before I can merge it.

@f52985
Copy link
Copy Markdown
Collaborator Author

f52985 commented Apr 24, 2026

Oh, the thing is, I somehow missed updating the test expectation for test-splice, but it revealed that the current implementation was actually incomplete: it missed the dependency if relations through function call. (i.e. the relation NotImmutReachable uses the definition $NotImmutReachable which uses the relation ImmutReachable, but this dependency through function is overlooked) I'm currently working on considering this dependency, which should be completed and pushed to this branch very soon.

@f52985
Copy link
Copy Markdown
Collaborator Author

f52985 commented Apr 27, 2026

Ping @f52985, this still needs updating test expectations before I can merge it.

Done, PTAL

@rossberg rossberg merged commit 18e6ed1 into main Apr 27, 2026
10 checks passed
@rossberg rossberg deleted the soundness.spectec branch April 27, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants